Anvil Chunk saving #401
Anvil Chunk saving #401
Conversation
| @@ -141,41 +186,300 @@ impl ChunkReader for AnvilChunkReader { | |||
| out | |||
| }; | |||
|
|
|||
| // TODO: check checksum to make sure chunk is not corrupted | |||
There was a problem hiding this comment.
Was a checksum implemented?
There was a problem hiding this comment.
not that i know, this was lucas comment
| ) | ||
| }); | ||
|
|
||
| region_file |
There was a problem hiding this comment.
This is incorrect, the pad should make the whole file a multiple of 4096, not just add 4096. It should be len(header) + len(bytes) + len(pad) % 4096 == 0
| } | ||
|
|
||
| sections.push(ChunkSection { | ||
| y: i as i8, |
There was a problem hiding this comment.
There can be -y heights, but i is a usize. Should there be a start_y passed in?
| @@ -189,16 +176,22 @@ impl Level { | |||
| self.chunk_watchers.shrink_to_fit(); | |||
| } | |||
|
|
|||
| pub fn write_chunk(&self, _chunk_to_write: (Vector2<i32>, Arc<RwLock<ChunkData>>)) { | |||
| //TODO | |||
| pub async fn write_chunk(&self, chunk_to_write: (Vector2<i32>, Arc<RwLock<ChunkData>>)) { | |||
There was a problem hiding this comment.
We need some kind of file lock so multiple threads don't try to write to the same file at the same time/read while the file is being written
|
For some reason currently loading vanilla chunks does not work when writing, when early return in the |
|
Looking for help, Mojang did a great job making this Format really complicated. If someone wants to help i would really appreciate it. |
Description
Add Chunk saving via the Anvil format.
More details on how the formats works can be found at https://minecraft.fandom.com/wiki/Region_file_format
Testing
Checklist
Things need to be done before this Pull Request can be merged.
Please follow our Coding Guidelines